feat(build): add BuildValue for values computed once per build - #112
Open
Princesseuh wants to merge 1 commit into
Open
feat(build): add BuildValue for values computed once per build#112Princesseuh wants to merge 1 commit into
Princesseuh wants to merge 1 commit into
Conversation
✅ Deploy Preview for maudit-framework ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
BuildValue: a value computed once per build from content and shared across every page that reads it viactx.build_value(&MY_VALUE).This replaces the pattern of one route computing something in its
render()and stashing it in a global for other routes to read. On incremental builds the producing route can be served from cache — skipping itsrender()— which leaves the global unset and breaks its readers. A build value is computed lazily on read, memoized for the rest of the build, and records its own content dependencies onto every page that reads it, so readers re-render exactly when the values inputs change.Also removes the unused
assets()method from theContentContexttrait, andPageContext::from_static_route/from_dynamic_routenow take a&BuildValueStore— both only affect code that drives the build loop directly instead of going throughcoronate().