Remove obsolete AC_HEADER_TIME to fix configure warning on Linux#23
Open
sendaoYan wants to merge 1 commit into
Open
Remove obsolete AC_HEADER_TIME to fix configure warning on Linux#23sendaoYan wants to merge 1 commit into
sendaoYan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AC_HEADER_TIMEmacro fromconfigure.ac../configureon non-Solaris hosts:./configure: line 4816: test: =: unary operator expectedProblem
AC_HEADER_TIMEis obsolete in Autoconf 2.71. The generatedconfigurescript contains legacy shell code:On Linux, ac_cv_header_sys_time_h is never set because the header check loop that populates it only runs inside the solaris*) branch. The empty variable expands to test = yes, which triggers the unary-operator error.
Configure still completes, but the warning is confusing and indicates broken autotools usage.
issue: #22
Solution
Drop AC_HEADER_TIME entirely. The project does not rely on TIME_WITH_SYS_TIME (it is obsolete); corkscrew.c includes <sys/time.h> directly.