Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 13, 2026

The codebase targets Java 8, but AgentManifestLibs.java used List.of() which was introduced in Java 9, causing compilation failures.

Changes:

  • Replaced List.of() with Collections.emptyList() on lines 54 and 60
  • Added Collections import
// Before (Java 9+)
return new ResolvedLibs(List.of(), List.of());

// After (Java 8 compatible)
return new ResolvedLibs(Collections.emptyList(), Collections.emptyList());

Both provide immutable empty lists with identical semantics.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link

@reviewabot reviewabot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not review PR. Too many requests in the last 5 minutes.
Max 1 pr 5 minutes. Last review was in btraceio/btrace at Tue, 13 Jan 2026 16:37:32 GMT.
Next review is available in approx 5 minutes.
Upgrade to a premium Reviewabot plan or contact us at support@reviewabot.com to request an exemption.

… compatibility

Co-authored-by: jbachorik <738413+jbachorik@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on style extensions and manifest-libs fix(agent): replace List.of() with Collections.emptyList() for Java 8 compatibility Jan 13, 2026
Copilot AI requested a review from jbachorik January 13, 2026 16:44
@jbachorik jbachorik marked this pull request as ready for review January 14, 2026 08:58
@jbachorik jbachorik merged commit a62169b into jb/configurations Jan 14, 2026
@jbachorik jbachorik deleted the copilot/sub-pr-791-again branch January 14, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants