BTI-1111 fix: change hardcoded wp-admin url#489
Merged
Conversation
Contributor
|
Hi @omnisite , Thank you for informing us about the issue you’ve encountered. |
vildanbina
approved these changes
Jun 22, 2026
Collaborator
|
@omnisite will you fix the conflicts? |
Author
|
@vildanbina these are in the dist files. That is why I commented in my PR that it would be best if you do the build and then commit the dist files. I can also do it, but there is no nvmrc file, so I do not know which version node must be used. |
# Conflicts: # assets/js/dist/blocks.asset.php # assets/js/dist/blocks.js
Collaborator
|
i merged develop and rebuilt the dist, conflicts are gone now. about the node version: there's no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded wp-admin URL gives a 404 in setups where wp-admin is renamed or in another location (like /wp/wp-admin/ in Bedrock setups). The current buckaroo_global.ajax_url is set to home('/') so that is why I added "admin_ajax_url" on "buckaroo_global". You should probably do your own npm run build (there was no .nvmrc so I used node 20).