feat: add retry logic for logins#274
Closed
aiell0 wants to merge 1 commit intobufbuild:mainfrom
Closed
Conversation
emcfarlane
reviewed
Apr 24, 2026
Collaborator
emcfarlane
left a comment
There was a problem hiding this comment.
Thanks for the PR. It would be good to correlate these failures with logs on our side before deciding if this is the right approach. If its a LB blip I think we can get away with a more conservative retry approach and apply it to more methods. I'm not sure if this is the right place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buf registry loginso transient BSR slowness does not fail the action immediatelylogin_retriesandlogin_retry_delay_secondsaction inputs with defaults of5retries and10seconds between attemptsdist/artifactsWhy
BSR login currently fails on the first slow or temporary registry response. This change makes login more resilient in CI while still allowing users to tune retry behavior when they need different timing.
Error
Testing
npm cinpm run lintnpm run build