Reduce visibility of previously internal package#309
Merged
Conversation
As part of refactoring, the previous internal package (where the validator implementation is found) was refactored to the build.buf.protovalidate package. As part of this change, we should ensure that all previously internal classes are final (to prevent subclassing) and that methods not overridden from an interface use package private or lower visibility.
pkwarren
commented
Jun 11, 2025
| final class RuleViolation implements Violation { | ||
| /** Static value to return when there are no violations. */ | ||
| public static final List<Builder> NO_VIOLATIONS = new ArrayList<>(); | ||
| static final List<Builder> NO_VIOLATIONS = Collections.emptyList(); |
Member
Author
There was a problem hiding this comment.
If for any reason someone mutated this list that would've been bad. This should also be faster and use less memory if there are no violations.
ghost
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of refactoring, the previous internal package (where the validator implementation is found) was refactored to the build.buf.protovalidate package. As part of this change, we should ensure that all previously internal classes are final (to prevent subclassing) and that methods not overridden from an interface use package private or lower visibility.