Conversation
stefanvanburen
commented
Jul 31, 2025
stefanvanburen
commented
- Use absolute instead of relative link for Buf logo, so it displays elsewhere (e.g. PyPI: https://pypi.org/project/protovalidate/)
- Use img.shields.io for version shield for consistency with other projects
* Use absolute instead of relative link for Buf logo, so it displays elsewhere (e.g. PyPI: https://pypi.org/project/protovalidate/) * Use img.shields.io for version shield for consistency with other projects
| [](https://github.com/bufbuild/protovalidate-python/actions/workflows/ci.yaml) | ||
| [](https://github.com/bufbuild/protovalidate-python/actions/workflows/conformance.yaml) | ||
| [](https://badge.fury.io/py/protovalidate) | ||
| [](https://pypi.org/project/protovalidate) |
There was a problem hiding this comment.
When I check https://img.shields.io/pypi/v/protovalidate, the image is orange. https://badge.fury.io/py/protovalidate.svg is green.
Does that indicate a problem/warning?
There was a problem hiding this comment.
Looking at https://shields.io/badges/py-pi-version, I don't think so; we can change the color= querystring parameter if it matters much?
I tend to look at attrs for guidance here as an established pypi project, and they seemingly have it blue, with the default value. I wonder if it's just because we're pre-1.0, or because we haven't set up trusted publishing yet?
There was a problem hiding this comment.
I think it's fine to use the default — I just wanted to make sure the change wasn't indicative of a problem. Nothing 404s, I'll approve this just now.
2 participants
