Fix re2 for protobuf_dot_fqn and add tests#466
Merged
timostamm merged 1 commit intoprotobuf-fqnfrom Feb 12, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
timostamm
commented
Feb 12, 2026
| id: "string.protobuf_dot_fqn" | ||
| message: "value must be a valid fully-qualified Protobuf name with a leading dot" | ||
| expression: "!rules.protobuf_dot_fqn || this == '' || this.matches('(\\\\.[A-Za-z_][A-Za-z_0-9]*)*$')" | ||
| expression: "!rules.protobuf_dot_fqn || this == '' || this.matches('^\\\\.[A-Za-z_][A-Za-z_0-9]*(\\\\.[A-Za-z_][A-Za-z_0-9]*)*$')" |
Member
Author
There was a problem hiding this comment.
While this.matches('(\\\\.[A-Za-z_][A-Za-z_0-9]*)*$') was just missing a start-of-line assertion, I prefer to keep the symmetry to protobuf_fqn.
| Message: &cases.StringProtobufFQN{Val: "my_package.MyMessage"}, | ||
| Expected: results.Success(true), | ||
| }, | ||
| "protobuf_fqn/_any_Crazy_CASE_with_01234_numbers/valid": { |
Member
Author
There was a problem hiding this comment.
srikrsna-buf
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic tests for the rules
string.protobuf_fqnandstring.protobuf_dot_fqnwe're adding in #465, and fixes a bug in the re2 expression forprotobuf_dot_fqn.The tests run successfully in bufbuild/protovalidate-es#131.