Skip to content

Retain "value" in documentation comments where applicable#467

Merged
timostamm merged 10 commits intovalue-wordingfrom
value-wording-comments
Feb 13, 2026
Merged

Retain "value" in documentation comments where applicable#467
timostamm merged 10 commits intovalue-wordingfrom
value-wording-comments

Conversation

@timostamm
Copy link
Member

@timostamm timostamm commented Feb 13, 2026

#442 removes references to "value" in error messages.

This

  • fixes documentation comments to retain "value" where applicable in afdb8ae,
  • updates the error messages for the new protobuf_fqn rules to drop the "value" reference in 0fff15d,
  • updates conformance tests for new error messages.

Tangentially related, 2e243d0 fixes a misleading reference to value in the comments on bytes.uuid.

The tests run successfully in bufbuild/protovalidate-es#132.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 13, 2026, 12:08 PM

@timostamm timostamm changed the title Value wording comments Retain "value" in documentation comments where applicable Feb 13, 2026
timostamm added a commit to bufbuild/protovalidate-es that referenced this pull request Feb 13, 2026
@timostamm timostamm merged commit 6f437db into value-wording Feb 13, 2026
6 checks passed
@timostamm timostamm deleted the value-wording-comments branch February 13, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants