Skip to content

refactor(acp): bump agent-client-protocol to 0.14.0#4893

Merged
bug-ops merged 1 commit into
mainfrom
acp-acp-protocol-bump
Jun 6, 2026
Merged

refactor(acp): bump agent-client-protocol to 0.14.0#4893
bug-ops merged 1 commit into
mainfrom
acp-acp-protocol-bump

Conversation

@bug-ops

@bug-ops bug-ops commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bump agent-client-protocol 0.12.1 → 0.14.0 and agent-client-protocol-schema = 0.13.6; remove dead agent-client-protocol-tokio dependency
  • Remove session/set_model handler (deleted upstream in 0.14.0); model switching preserved via stable session/set_config_option (config_id="model") and $/model slash command
  • Remove inbound/outbound message-id echo (PromptRequest.message_id and PromptResponse.user_message_id deleted upstream in schema 0.13.6)
  • Rename provider ext-method types to singular (SetProvidersRequest/ResponseSetProviderRequest/Response, DisableProvidersDisableProvider)
  • Fix unstable-session-usage feature gate rename (now maps to unstable_end_turn_token_usage); add core passthrough to unstable-elicitation
  • Degate logout/session-delete/session-resume/additional-directories handlers (stable in core 0.14.0); feature names retained as no-op tombstones for workspace forwarding

Breaking Changes

  • session/set_model RPC removed (upstream). No capability loss — model switching continues via session/set_config_option (config_id="model").
  • PromptRequest.message_id and PromptResponse.user_message_id removed upstream; inbound message-id echo no longer available.

Test plan

  • cargo nextest run -p zeph-acp --all-features — 138 tests pass
  • RUSTFLAGS="-D warnings" cargo check --workspace --features ide — clean
  • cargo clippy -p zeph-acp --all-features -- -D warnings — clean
  • cargo deny check advisories — only pre-existing RUSTSEC-2025-0134 (qdrant/rustls-pemfile, unrelated)
  • Manual ACP live round-trip required post-merge (CLAUDE.md LLM-serialization gate): session/new → prompt → stream → set_config_option{model} → set_mode → delete → logout

…dlers

- Bump agent-client-protocol 0.12.1 → 0.14.0 and agent-client-protocol-schema
  to =0.13.6; remove dead agent-client-protocol-tokio dependency
- Delete session/set_model handler (removed upstream); model switching preserved
  via stable session/set_config_option (config_id="model") and $/model slash
- Remove all inbound message-id echo plumbing (PromptRequest.message_id and
  PromptResponse.user_message_id deleted upstream in schema 0.13.6)
- Rename provider ext-method types to singular: SetProvidersRequest/Response →
  SetProviderRequest/Response, DisableProviders → DisableProvider
- Fix unstable-session-usage feature to point to unstable_end_turn_token_usage
  (gate rename, not stabilization); add core passthrough to unstable-elicitation
- Degate logout/session-delete/session-resume/additional-directories handlers
  (all stable in core 0.14.0); retain feature names as no-op tombstones for
  workspace forwarding compatibility
- Update specs/013-acp, CHANGELOG, and crates/zeph-acp/README for the bump
@github-actions github-actions Bot added documentation Improvements or additions to documentation rust Rust code changes dependencies Dependency updates refactor Code refactoring without functional changes size/XL Extra large PR (500+ lines) labels Jun 5, 2026
@bug-ops bug-ops enabled auto-merge (squash) June 5, 2026 23:57
@bug-ops bug-ops merged commit 8e89497 into main Jun 6, 2026
36 checks passed
@bug-ops bug-ops deleted the acp-acp-protocol-bump branch June 6, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates documentation Improvements or additions to documentation refactor Code refactoring without functional changes rust Rust code changes size/XL Extra large PR (500+ lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant