worker: factor out video codec to be easily configurable

[rroohhh]

Then we can switch (more easily) to h264_videotoolbox on the mac worker.

[anuejn]

I dont really understand just from the code how this would be used. Where is data["REENCODE_VIDEO_CODEC"] coming from?

[phlmn]

Then we can switch (more easily) to h264_videotoolbox on the mac worker.

Is this a good idea? Encoding is already pretty fast and h264_videotoolbox is a bit crappy (e.g. it does not support crf)...

[rroohhh]

I dont really understand just from the code how this would be used. Where is data["REENCODE_VIDEO_CODEC"] coming from?

From the line above REENCODE_PROFILES. That way one can simply set REENCODE_VIDEO_CODEC as env var (instead of having to set the whole profiles via an env var.

Then we can switch (more easily) to h264_videotoolbox on the mac worker.

Is this a good idea? Encoding is already pretty fast and h264_videotoolbox is a bit crappy (e.g. it does not support crf)...

Well, good question. Somehow its just strictly slower using videotoolbox (which does by now support constant quality coding using q:v btw). So I guess it would not make any sense to move to videotoolbox.