on_new_slide Callback Option Implemented#58
Open
f3ndot wants to merge 2 commits intobuildinternet:masterfrom
Open
on_new_slide Callback Option Implemented#58f3ndot wants to merge 2 commits intobuildinternet:masterfrom
f3ndot wants to merge 2 commits intobuildinternet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I personally found it useful for the plugin to provide a callback option when a new slide / image is displayed. I've written in support under the option name of "on_new_slide". Demo of this is in demo.html and I've updated the version number to 3.2.8 as a result of this addition.
First time doing this, so let me know if I've done something wrong. I believe it's alright.