-
-
Notifications
You must be signed in to change notification settings - Fork 21
change fail-fast to false for regression test workflow #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1845 +/- ##
==========================================
- Coverage 80.94% 80.17% -0.77%
==========================================
Files 59 58 -1
Lines 6595 6572 -23
Branches 1143 1128 -15
==========================================
- Hits 5338 5269 -69
- Misses 1256 1302 +46
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fb4044a to
6fe1f0c
Compare
…ile traversal limit of 1
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables fast-failure in the regression workflow and standardizes exception handling across CLI commands, updating tests and configuration examples to match the new error types.
- Set
fail-fast: falsein.github/workflows/regression.yml - Replaced
sys.exitcalls withraise SystemExitand updated exception imports - Adjusted tests and YAML examples to reflect new paths and exception types
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/regression.yml | Disabled fail-fast for matrix jobs |
| buildtest/cli/cdash.py | Switched to raise SystemExit, updated exception import, removed old response check |
| buildtest/cli/buildspec.py | Unified exit behavior by raising SystemExit |
| tests/cli/test_config.py | Updated path to invalid buildspec in test |
| tests/cli/test_cdash.py | Aligned exception type, removed outdated test block |
| tests/cli/cdash_examples/invalid_url.yml | Adjusted YAML fields for moduletool and report sections |
| tests/cli/cdash_examples/invalid_project.yml | Removed obsolete example file |
| pyproject.toml | Changed pytest flags to use --maxfail=5 instead of -x |
Comments suppressed due to low confidence (3)
tests/cli/test_cdash.py:62
- By removing the test block for invalid project names, we lose coverage for handling invalid CDASH projects; consider adding a test to cover that scenario.
with pytest.raises(requests.exceptions.ConnectionError):
tests/cli/test_config.py:204
- The test now points to 'invalid_executors.yml' under the tutorials directory, but this file doesn't appear to exist; ensure the path and filename are correct or add the missing file to avoid failures.
buildspecs=[os.path.join(BUILDTEST_ROOT, "tutorials", "invalid_executors.yml")],
buildtest/cli/cdash.py:135
- The removal of the upload response validation (checking for
<status>OK</status>) removes an important sanity check; consider reintroducing validation or logging to detect malformed CDASH responses.
except requests.exceptions.ConnectionError:
|
|
||
| # in configuration file we have invalid url to CDASH server | ||
| with pytest.raises(requests.ConnectionError): | ||
| # with pytest.raises(urllib3.exceptions.MaxRetryError): |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the commented-out exception check for urllib3; it is no longer relevant and clutters the test.
| # with pytest.raises(urllib3.exceptions.MaxRetryError): |
buildtest/cli/buildspec.py
Outdated
| msg=f"[red]{exception_counter} buildspecs failed to validate" | ||
| console.print(msg) | ||
| raise SystemExit(msg) | ||
| # sys.exit(1) |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented-out sys.exit(1) is dead code after raising SystemExit; consider removing it to clean up the code.
| # sys.exit(1) |
No description provided.