Skip to content

Conversation

@shahzebsiddiqui
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (c7a26f2) to head (c94e90f).
Report is 26 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1845      +/-   ##
==========================================
- Coverage   80.94%   80.17%   -0.77%     
==========================================
  Files          59       58       -1     
  Lines        6595     6572      -23     
  Branches     1143     1128      -15     
==========================================
- Hits         5338     5269      -69     
- Misses       1256     1302      +46     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shahzebsiddiqui shahzebsiddiqui force-pushed the relax_regression_test_failure branch from fb4044a to 6fe1f0c Compare June 18, 2025 20:37
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 18, 2025
@shahzebsiddiqui shahzebsiddiqui requested a review from Copilot June 18, 2025 22:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables fast-failure in the regression workflow and standardizes exception handling across CLI commands, updating tests and configuration examples to match the new error types.

  • Set fail-fast: false in .github/workflows/regression.yml
  • Replaced sys.exit calls with raise SystemExit and updated exception imports
  • Adjusted tests and YAML examples to reflect new paths and exception types

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/regression.yml Disabled fail-fast for matrix jobs
buildtest/cli/cdash.py Switched to raise SystemExit, updated exception import, removed old response check
buildtest/cli/buildspec.py Unified exit behavior by raising SystemExit
tests/cli/test_config.py Updated path to invalid buildspec in test
tests/cli/test_cdash.py Aligned exception type, removed outdated test block
tests/cli/cdash_examples/invalid_url.yml Adjusted YAML fields for moduletool and report sections
tests/cli/cdash_examples/invalid_project.yml Removed obsolete example file
pyproject.toml Changed pytest flags to use --maxfail=5 instead of -x
Comments suppressed due to low confidence (3)

tests/cli/test_cdash.py:62

  • By removing the test block for invalid project names, we lose coverage for handling invalid CDASH projects; consider adding a test to cover that scenario.
    with pytest.raises(requests.exceptions.ConnectionError):

tests/cli/test_config.py:204

  • The test now points to 'invalid_executors.yml' under the tutorials directory, but this file doesn't appear to exist; ensure the path and filename are correct or add the missing file to avoid failures.
            buildspecs=[os.path.join(BUILDTEST_ROOT, "tutorials", "invalid_executors.yml")],

buildtest/cli/cdash.py:135

  • The removal of the upload response validation (checking for <status>OK</status>) removes an important sanity check; consider reintroducing validation or logging to detect malformed CDASH responses.
    except requests.exceptions.ConnectionError:


# in configuration file we have invalid url to CDASH server
with pytest.raises(requests.ConnectionError):
# with pytest.raises(urllib3.exceptions.MaxRetryError):
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented-out exception check for urllib3; it is no longer relevant and clutters the test.

Suggested change
# with pytest.raises(urllib3.exceptions.MaxRetryError):

Copilot uses AI. Check for mistakes.
msg=f"[red]{exception_counter} buildspecs failed to validate"
console.print(msg)
raise SystemExit(msg)
# sys.exit(1)
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out sys.exit(1) is dead code after raising SystemExit; consider removing it to clean up the code.

Suggested change
# sys.exit(1)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants