Merged
Conversation
## Which issue does this PR close? - Closes #20856. ## Rationale for this change Replace pull-based `ParquetMetaDataReader` with push-based `ParquetMetaDataPushDecoder`, which decouples IO from decoding. We don't actually do this in this PR, just use the different API to make it more obvious it is possible. ## What changes are included in this PR? - Replace `ParquetMetaDataReader` with `ParquetMetaDataPushDecoder` ## Are these changes tested? Covered by existing tests — this is a behavioral-equivalent replacement of the metadata reading path. ## Are there any user-facing changes? No user-facing API changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
## Which issue does this PR close? ## Rationale for this change ## What changes are included in this PR? ## How are these changes tested? - All existing sqllogictests pass (419 files) including TPC-H - Updated test expectations to reflect eliminated `ProjectionExec` nodes - Net reduction of 72 lines across test files (fewer plan operators) ## Are there any user-facing changes? No, only more efficient plans 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )