Fixed crash in some cases when invalid session cookie was present.#7
Open
vgrichina wants to merge 1 commit into
Open
Fixed crash in some cases when invalid session cookie was present.#7vgrichina wants to merge 1 commit into
vgrichina wants to merge 1 commit into
Conversation
getCookie in such cases had wrong behavior – even after the new session was created, old cookie was still returned.
|
Burt Beckwith » grails-database-session #6 SUCCESS |
|
would love it if this pull request could be merged. I've forked the project and applied it by hand so I could pick up this functionality. This fixes a problem for me that when the session is invalidated (say, editing the value of the SessionProxyFilter_SessionId cookie to something that doesn't exist), the next call would (in my application) create multiple new sessions (one per call to request.getSession()) with only the last one being used. After this patch, only one new session is created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCookie in such cases had wrong behavior – even after the new session was created, old cookie was still returned.