Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1 +/- ##
===========================================
+ Coverage 13.22% 34.95% +21.73%
===========================================
Files 4 3 -1
Lines 121 123 +2
Branches 70 72 +2
===========================================
+ Hits 16 43 +27
+ Misses 101 59 -42
- Partials 4 21 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
Author
|
Now just needs docs for all the added stuff. |
bwhitchurch
commented
Jan 30, 2023
Owner
Author
bwhitchurch
left a comment
bwhitchurch
left a comment
There was a problem hiding this comment.
Needs documentation for added stuff. May be a couple of missed deletions from refactoring cube.hpp.
| /*! | ||
| * @brief number of faces on a cube. | ||
| */ | ||
| constexpr size_t num_cube_faces = 6; |
Owner
Author
There was a problem hiding this comment.
These constants may not be necessary anymore. Should remove them
| {CubeFace::LEFT, 'L'}, | ||
| {CubeFace::FRONT, 'F'}, | ||
| {CubeFace::BACK, 'B'}}}}; | ||
| constexpr size_t num_turns = 3; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a better reflective enum (inspired by BetterEnums) to replace biEnum. Refactor existing code in cube.hpp and scrambler to use new enum stuff.