Open
Conversation
Previously had an error connection refused. Fix "-p 8080:80" to "-p 80:80". Port 80 instead of 8080 was exposed in Dockerfile. Now it should work when trying to access from outside the container.
Owner
|
I do not agree: The documentation is meant to show how to map another Host's port to the internal port 80. This is common practice if you have multiple containers running on the same host. |
bylexus
requested changes
Jan 3, 2018
Owner
bylexus
left a comment
There was a problem hiding this comment.
-
I do not agree to the README.md file change: It is intentional that this is documented as Port 8080:80, as this is the common use case for docker containers. Please remove this change.
-
Agree to the Dockerfile change, I will accept this change, but please create a new pull request: You're mixing 2 changes under the same title here.
--> Please change this request as suggested:
- Remove the README.md change
- Rename the change request, as the title now says "Updated README.md"
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously had an error connection refused. Fix "-p 8080:80" to "-p 80:80". Port 80 instead of 8080 was exposed in Dockerfile. Now it should work when trying to access from outside the container.