feat(#567): admin UI for channel API keys - #608
Open
sneumannb5 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
/admin/api-keys(create/list/revoke) for the channel API keys exposed bycreateAdminKeysRouter, which shipped in #438/#439 with no web-ui page. Closes #567 (follow-through from #550).Why
Keys could only be minted via
curl, and a public MCP key-binding (#550) is keyed onApiKeyRecord.id- so an operator had to read that id out of the API by hand. Each key row now shows the id verbatim with a one-click copy, plus a reveal-once token, ascopes:[]guard, and a two-step revoke.Test plan
npm run typecheckin web-uinpx eslint app/admin/api-keys app/_lib/api.ts app/admin/page.tsxnpx vitest run app/admin/api-keys- 15/15 pass (incl. copy-id flow + 2 concurrency regression guards)npm run i18n:check- en/de parity, 3379 keysRisk / blast radius
Frontend only — the channel-api router is unchanged (no schema, no public API, no env-var). Auth inherits the existing
/apioperator-session gate. No rotate path by design (revoke + replace).Naming-decisions still pending
/admin/api-keys(matches the feat(web-ui): admin UI for public API keys (issues #438/#439) #551 convention + card keyapiKeys), not the literal/admin/keysfrom the issue title - confirm before mergeNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.