Redline maven plugin - #131
Draft
andreaTP wants to merge 3 commits into
Draft
Conversation
andreaTP
force-pushed
the
redline-maven-plugin
branch
4 times, most recently
from
July 29, 2026 20:20
b659f62 to
7b5388f
Compare
Contributor
Author
|
on hold, not having jffi requires too much Java versions contorsionism. |
Architecture: - Bridge module uses exec:java with Generator.main() instead of the Maven plugin, breaking the circular dependency (plugin → redline → bridge → plugin) - New redline/build-time-compiler module with RedlineGenerator that handles native code generation and extends generated sources with builder()/safeBuilder()/loadNativeCode() methods - Maven plugin calls RedlineGenerator when <redlineTargets> is configured Config extended with: - redlineTargets: list of target triples for cross-compilation - targetResourceFolder: where .native files are written Generated module class gains (when redlineTargets configured): - loadNativeCode(): loads platform-specific native code from resources - builder(): automatic backend selection (native if platform + Java 25 supported, bytecode otherwise) - safeBuilder(): always uses bytecode compiler NativeMachineFactory.Builder gains toInstanceBuilder() to return a configured Instance.Builder for the generated builder() method. RedlineTarget gains fromTriple() for target triple lookup.
- Add <redline>true</redline> shortcut to compile for all supported platforms (instead of listing 6 target triples) - Add redline/it module with Maven Invoker integration test: - Compiles add.wat.wasm with native code for all platforms - Tests builder() (native), safeBuilder() (bytecode), loadNativeCode() - Verifies native and bytecode produce identical results - Add logging when redline native compilation runs
andreaTP
force-pushed
the
redline-maven-plugin
branch
from
August 4, 2026 17:40
7b5388f to
66ffb2e
Compare
- Add Rust toolchain + cranelift_bridge.wasm build to ci.yaml - Remove -Predline from release.yaml and redline.yaml - Plugin depends directly on redline-build-time-compiler (no reflection) - Bridge uses exec:java with GeneratorMain to break the cycle - Generated code uses NativeMachineFactoryProvider SPI (no Panama import) - Remove redundant targetResourceFolder from Config - Validate target triples before compilation in RedlineGenerator - E2E tests: JFFI (all JDKs) + Panama (JDK 25+ only) - Restore javadoc comments on Mojo fields
andreaTP
force-pushed
the
redline-maven-plugin
branch
from
August 10, 2026 10:18
401e2a6 to
f58545f
Compare
andreaTP
commented
Aug 10, 2026
| } | ||
|
|
||
| @Test | ||
| public void nativeCodeIsAvailable() { |
Contributor
Author
There was a problem hiding this comment.
this is machine dependent
| "var host = RedlineTarget.detectHost().orElse(null);")); | ||
|
|
||
| initBody.addStatement( | ||
| StaticJavaParser.parseStatement( |
Contributor
Author
There was a problem hiding this comment.
no parseStatement + string interpolation, we should use plain JavaParser to build the desired code, is more maintainable in the longer run
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.github.javaparser</groupId> | ||
| <artifactId>javaparser-core</artifactId> |
Contributor
Author
There was a problem hiding this comment.
javaparser as a dependency of the build time compiler looks a little strange, but maybe worth if it keeps complexity low.
| </dependency> | ||
| <dependency> | ||
| <groupId>run.endive</groupId> | ||
| <artifactId>runtime</artifactId> |
Contributor
Author
There was a problem hiding this comment.
isn't runtime a transitive dependency of redline?
| <dependencies> | ||
| <dependency> | ||
| <groupId>run.endive</groupId> | ||
| <artifactId>redline-api-experimental</artifactId> |
Contributor
Author
There was a problem hiding this comment.
do we need to explicitly add the api module? isn't it transitive from runner?
| <configuration> | ||
| <name>endive.test.AddModule</name> | ||
| <wasmFile>src/test/resources/add.wat.wasm</wasmFile> | ||
| <interpreterFallback>WARN</interpreterFallback> |
| } | ||
|
|
||
| @Test | ||
| public void nativeCodeIsAvailable() { |
Contributor
Author
There was a problem hiding this comment.
this is machine dependent
| <version>0.0-SNAPSHOT</version> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <dependencies> |
Contributor
Author
There was a problem hiding this comment.
same comments as above for the transitive deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.