Add a port_getn_query function.
#1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solarish [`port_getn` function] special-cases a `max` argument value of 0 to be a query of the number of events available. #1215 added a special-case to protect the code from doing a resize in that case. And in case users actually do want to do a query, this PR adds a new `port_getn_query` function that passes a zero. [`port_getn` function]: https://illumos.org/man/3C/port_getn
Berrysoft
reviewed
Nov 18, 2024
Co-authored-by: 王宇逸 <Strawberry_Str@hotmail.com>
Berrysoft
approved these changes
Nov 18, 2024
Contributor
Berrysoft
left a comment
Berrysoft
left a comment
There was a problem hiding this comment.
I'm expecting a new publish for the fixes to port_getn.
sunfishcode
added a commit
that referenced
this pull request
Nov 18, 2024
* Add a `port_getn_query` function. The solarish [`port_getn` function] special-cases a `max` argument value of 0 to be a query of the number of events available. #1215 added a special-case to protect the code from doing a resize in that case. And in case users actually do want to do a query, this PR adds a new `port_getn_query` function that passes a zero. [`port_getn` function]: https://illumos.org/man/3C/port_getn * Fix errors. * Update src/event/port.rs Co-authored-by: 王宇逸 <Strawberry_Str@hotmail.com> --------- Co-authored-by: 王宇逸 <Strawberry_Str@hotmail.com>
sunfishcode
added a commit
that referenced
this pull request
Nov 18, 2024
* Add a `port_getn_query` function. The solarish [`port_getn` function] special-cases a `max` argument value of 0 to be a query of the number of events available. #1215 added a special-case to protect the code from doing a resize in that case. And in case users actually do want to do a query, this PR adds a new `port_getn_query` function that passes a zero. [`port_getn` function]: https://illumos.org/man/3C/port_getn * Fix errors. * Update src/event/port.rs Co-authored-by: 王宇逸 <Strawberry_Str@hotmail.com> --------- Co-authored-by: 王宇逸 <Strawberry_Str@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solarish
port_getnfunction special-cases amaxargument value of 0 to be a query of the number of events available. #1215 added a special-case to protect the code from doing a resize in that case. And in case users actually do want to do a query, this PR adds a newport_getn_queryfunction that passes a zero.