fuzzgen: Enable select with float arms
#6883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameysharp
approved these changes
Aug 22, 2023
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
Have you run this with the icache fuzz target, to check that we have lowerings on all backends? Assuming that's not going to start failing, this is clearly a good idea.
github-actions
bot
added
the
cranelift
Contributor
Author
|
Looks like RISC-V is the only backend that does not implement |
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 6, 2023
* fuzzgen: Enable `select` with float arms * fuzzgen: Disable `select_spectre_guard` with float arms on RISC-V
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR enables the
selectandselect_spectre_guardinstructions with float arms on fuzzgen. This should have probably been the first thing I checked when looking at why fuzzgen didn't find #6859, but it was pretty much the last 🙃 .Even with this it still took a really long time to reproduce the issue, which isn't great. But we can now theoretically find it.