Skip to content

Room-scale movement synchronization #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincentfretin merged 5 commits into from
Apr 1, 2026
Merged

Room-scale movement synchronization #464

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01b6e5c
Add room-scale movement components
KickSuch Dec 10, 2025
e8e5fe4
Revert "Add room-scale movement components"
KickSuch Dec 17, 2025
ff92595
Fix nav-mesh clamping for room-scale VR
KickSuch Dec 17, 2025
abce221
Add reuseable vector and make camera offset calculations only in vr
KickSuch Dec 22, 2025
c0601a7
Modify conditions to not compute next position unnecessarily when no …
vincentfretin Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions src/controls/movement-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ AFRAME.registerComponent('movement-controls', {
const start = new THREE.Vector3();
const end = new THREE.Vector3();
const clampedEnd = new THREE.Vector3();
const cameraOffset = new THREE.Vector3();

return function (t, dt) {
if (!dt) return;
Expand All @@ -108,7 +109,8 @@ AFRAME.registerComponent('movement-controls', {
const velocityCtrl = this.velocityCtrl;
const velocity = this.velocity;

if (!velocityCtrl) return;
const isInVR = this.el.sceneEl.is('vr-mode');
if (!velocityCtrl && !isInVR) return;

// Update velocity. If FPS is too low, reset.
if (dt / 1000 > MAX_DELTA) {
Expand All @@ -118,24 +120,42 @@ AFRAME.registerComponent('movement-controls', {
}

if (data.constrainToNavMesh
&& velocityCtrl.isNavMeshConstrained !== false) {
&& ((!velocityCtrl && isInVR) || velocityCtrl.isNavMeshConstrained !== false)) {

if (velocity.lengthSq() < EPS) return;

start.copy(el.object3D.position);
end
.copy(velocity)
.multiplyScalar(dt / 1000)
.add(start);
if (isInVR) {
const cameraEl = data.camera;
cameraEl.object3D.getWorldPosition(cameraOffset);
if (el.object3D.parent) {
el.object3D.parent.worldToLocal(cameraOffset);
}
cameraOffset.sub(el.object3D.position);
cameraOffset.y = 0;
start.add(cameraOffset);
}

if (velocityCtrl) {
Copy link
Copy Markdown
Member

@vincentfretin vincentfretin Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to check for velocityCtrl if you revert the first line change

Copy link
Copy Markdown
Contributor Author

@KickSuch KickSuch Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first change must stay

end
.copy(velocity)
.multiplyScalar(dt / 1000)
.add(start);
} else {
end.copy(start)
}

const nav = el.sceneEl.systems.nav;
this.navGroup = this.navGroup === null ? nav.getGroup(start) : this.navGroup;
this.navNode = this.navNode || nav.getNode(start, this.navGroup);
this.navNode = nav.clampStep(start, end, this.navGroup, this.navNode, clampedEnd);
if (isInVR) {
clampedEnd.sub(cameraOffset);
}
el.object3D.position.copy(clampedEnd);
} else if (el.hasAttribute('velocity')) {
} else if (velocityCtrl && el.hasAttribute('velocity')) {
el.setAttribute('velocity', velocity);
} else {
} else if (velocityCtrl) {
el.object3D.position.x += velocity.x * dt / 1000;
el.object3D.position.y += velocity.y * dt / 1000;
el.object3D.position.z += velocity.z * dt / 1000;
Expand Down