ENH/SE: don't deadreckon position

[jklymak]

This closes #4

For raw_to_timeseries I've added a new kwarg deadreckon=False which ignores the dead reckoning, and only has valid lat and Lon when the glider is on the surface.

This is the default, but if you use NAV_LATITUDE and NAV_LONGITUDE in the yaml, you probably want to change to Lat and Lon respectively to pick up the lat and Lon in the glider file.

[Copilot]

Pull Request Overview

This PR adds a deadreckon flag to raw_to_timeseries, updates tests and example scripts to exercise both modes, and adjusts example YAML to use surface latitude/longitude (Lat/Lon) instead of dead-reckoned fields.

• Introduce deadreckon=False parameter in raw_to_timeseries to ignore underwater dead-reckoning jumps
• Update tests and example scripts to pass deadreckon flag explicitly
• Change example deployment YAML to reference Lat/Lon as sources for latitude and longitude

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File	Description
tests/test_pyglider.py	Pass deadreckon=True to raw_to_L0timeseries calls
tests/example-data/.../process_deploymentRealTime.py	Add deadreckon=False to example script invocation
tests/example-data/.../deploymentRealtime.yml	Switch latitude/longitude source: keys to Lat/Lon
pyglider/seaexplorer.py	Implement deadreckon logic for filtering lat/lon

Comments suppressed due to low confidence (2)

tests/test_pyglider.py:100

• [nitpick] There’s no test covering the default deadreckon=False path—adding a case to confirm that underwater positions are set to NaN when deadreckon is not passed would help ensure correct behavior.

seaexplorer.raw_to_L0timeseries(

tests/test_pyglider.py:101

• Verify that raw_to_L0timeseries actually accepts a deadreckon keyword argument; if not, either update that function or change this test to call raw_to_timeseries directly.

rawncdir, l0tsdir, deploymentyaml_raw, kind='raw', deadreckon=True

[Copilot]

Pull Request Overview

This PR introduces a deadreckon option to raw_to_timeseries that disables dead-reckoned positions and only uses valid surface fixes for lat/lon. It also updates tests, example scripts, and YAML to pass the new flag and adjust coordinate sources.

• Add deadreckon keyword (default False) to raw_to_timeseries and implement helper functions to drop and forward‐fill coordinates.
• Update unit tests and example workflows to pass the deadreckon flag.
• Change example deployment YAML to use Lat/Lon sources instead of NAV_LATITUDE/NAV_LONGITUDE.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

File	Description
tests/test_pyglider.py	Updated calls to include deadreckon=True in timeseries tests
tests/example-data/.../process_deploymentRealTime.py	Pass deadreckon=False to raw_to_timeseries in example script
tests/example-data/.../deploymentRealtime.yml	Switch lat/lon sources from NAV_LATITUDE/NAV_LONGITUDE to Lat/Lon
pyglider/seaexplorer.py	Added deadreckon parameter, _forward_fill & _drop_if helpers, and coordinate‐dropping logic

Comments suppressed due to low confidence (2)

tests/test_pyglider.py:101

• The test calls raw_to_L0timeseries with deadreckon=True, but raw_to_L0timeseries may not accept that parameter. Either extend its signature to pass through deadreckon or update the test to call raw_to_timeseries directly.

outname = seaexplorer.raw_to_L0timeseries(rawncdir, l0tsdir, deploymentyaml_raw, kind='raw', deadreckon=True)

tests/test_pyglider.py:150

• Similarly, this call to raw_to_L0timeseries passes deadreckon=True but the function signature doesn't include it. Consider updating that function or test accordingly.

outname_interp_raw = seaexplorer.raw_to_L0timeseries(rawncdir, l0tsdir_interp_raw, interp_yaml, kind='raw', deadreckon=True)

[Copilot]

[nitpick] Docstring for _drop_if is hardcoded to 'Lat' and 'DeadReckoning'; generalize to mention parameters todo, condit, and value.

Suggested change

	"""Drop Lat if DeadReckoning is 1"""
	"""
	Drop values in the column specified by `todo` if the column specified by `condit` equals `value`.
	Parameters:
	gli (polars.DataFrame): The input DataFrame.
	todo (str): The name of the column to modify.
	condit (str): The name of the column to check the condition against.
	value (any): The value to compare against in the `condit` column.
	Returns:
	polars.DataFrame: The modified DataFrame with updated values in the `todo` column.
	"""

[jklymak]

@richardsc can you guys test this when you get a chance?

[richardsc]

Hi @jklymak -- sorry for being slow. @clayton33 and I were re-running some of our missions to see if this behaved as expected. It does!

(though as a heads-up we will be working through some other issues we found, in the case where a user might actually want to keep and use some of these nav variables, such as deadReckoning, navState, etc).