Open
Conversation
chqrlie
force-pushed
the
warnings
branch
3 times, most recently
from
d5b5487 to
b854cf0
Compare
chqrlie
force-pushed
the
warnings
branch
4 times, most recently
from
f0a772e to
c797340
Compare
chqrlie
force-pushed
the
warnings
branch
2 times, most recently
from
26d5039 to
e9d9457
Compare
chqrlie
force-pushed
the
warnings
branch
5 times, most recently
from
0f25359 to
0bac7de
Compare
chqrlie
force-pushed
the
warnings
branch
4 times, most recently
from
9047df3 to
921edd4
Compare
chqrlie
force-pushed
the
warnings
branch
2 times, most recently
from
9568b9f to
5c1f4d5
Compare
Member
|
Looking at the branch, I think it makes the system a bit more complex, while not actually offering any real benefit that I see. It does seem to slow down the analysing a little. I prefer going with keep-it-simple.. |
chqrlie
force-pushed
the
warnings
branch
5 times, most recently
from
c221bb6 to
2c72c63
Compare
chqrlie
force-pushed
the
warnings
branch
3 times, most recently
from
7e74c86 to
4192e4a
Compare
* add `WarningKind` enumeration and simplify `Flags` structure * rename `warning_flags.Flags` as `WarningFlags` * remove temporary unreachable code hack * all targets have all warnings enabled by default * extend `WarningFlags` type with type functions * simplify `Target.enableWarnings()` and `Target.disableWarnings()` * add warnings for `const-return-type` and `idiomatic-parentheses` * accept both '$warnings unused' and '$warnings no-unused' etc. * enable warning/error on unreachable code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WarningKindenumeration and simplifyFlagsstructurewarning_flags.FlagsasWarningFlagsWarningFlagstype with type functionsTarget.enableWarnings()andTarget.disableWarnings()const-return-typeandidiomatic-parentheses