Open
Conversation
Contributor
chqrlie
commented
Mar 21, 2026
chqrlie
commented
- support function pointer type definitions
bvdberg
reviewed
Mar 22, 2026
libs/libc/libc_dirent.c2i
Outdated
| #if EXPERIMENTAL | ||
| typedef int (*FilterFn)(const Dirent*); | ||
| typedef int (*DirentCompareFn)(const Dirent**, const Dirent**); | ||
| #else |
Member
There was a problem hiding this comment.
I'm not sure if I like seeing old C format typedefs in a .c2i file..it seems a bit weird. It looks more like C for course, but the c2i file is a C2 file, not a C file..
chqrlie
force-pushed
the
c-types
branch
5 times, most recently
from
c75f2db to
28fa806
Compare
* support C function pointer type definitions * remove USE_NATIVE_CTYPES feature as bootstrap now supports this * remove function type definitions in stdlib.c2i and libc_dirent.c2i * simplify c_types.c2i
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.