Drop py36, add tests against py39 #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.10 seems to break lines in different places to earlier versions.
This reverts commit 680fc1b.
Closed
Contributor
Author
|
Outstanding questions; should we drop EOL versions just because they're EOL, or should we keep them around as long as they work, and let every subsequent contributor decide whether their particular usage of modern features is the one which motivates kicking off the old version? IMO, tools dropping support for unsupported python versions is the only way to keep the ecosystem moving forward, as well as simplifying the dev and test process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #226 , as it uses the GHA config.
Originally included 3.10 as well but there's some subtle difference in the
--helpoutput format which needs a bit more care, where this goes in nice and easy.