Skip to content

⚡ Bolt: Offload blocking I/O to background tasks #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acebytes wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −6
Open

⚡ Bolt: Offload blocking I/O to background tasks #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Offloading Blocking Tasks from @MainActor
**Learning:** In Swift, synchronous, blocking operations like `Foundation.Process.waitUntilExit()`, `readDataToEndOfFile()`, and `DiskInfo.current()` will freeze the UI if executed within an `@MainActor` context (like a ViewModel).
**Action:** Use `await Task.detached { ... }.value` to offload these blocking operations to a background thread, preventing UI unresponsiveness and adhering to structured concurrency best practices.
14 changes: 8 additions & 6 deletions Sources/Cacheout/ViewModels/CacheoutViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class CacheoutViewModel: ObservableObject {
func scan() async {
isScanning = true
isNodeModulesScanning = true
diskInfo = DiskInfo.current()
diskInfo = await Task.detached { DiskInfo.current() }.value

// Scan caches and node_modules in parallel
async let cacheResults = scanner.scanAll(CacheCategory.allCategories)
Expand Down Expand Up @@ -241,10 +241,12 @@ class CacheoutViewModel: ObservableObject {
]

do {
try process.run()
process.waitUntilExit()
let data = pipe.fileHandleForReading.readDataToEndOfFile()
let output = String(data: data, encoding: .utf8) ?? ""
let output: String = try await Task.detached {
try process.run()
process.waitUntilExit()
let data = pipe.fileHandleForReading.readDataToEndOfFile()
return String(data: data, encoding: .utf8) ?? ""
}.value

if process.terminationStatus == 0 {
// Extract "Total reclaimed space:" line
Expand All @@ -270,7 +272,7 @@ class CacheoutViewModel: ObservableObject {
}

// Refresh disk info after prune
diskInfo = DiskInfo.current()
diskInfo = await Task.detached { DiskInfo.current() }.value
}

func clean() async {
Expand Down