🎨 Palette: Expanded row hit targets and improved VoiceOver support#62
🎨 Palette: Expanded row hit targets and improved VoiceOver support#62
Conversation
Wrapped the inner `HStack` inside `CategoryRow` and `NodeModulesRow` in a `Button` to vastly expand the hit target for selecting/deselecting items. Added `.contentShape(Rectangle())` to allow clicking the empty space, and applied `.accessibilityElement(children: .combine)` to ensure VoiceOver reads the row sequentially rather than separating the checkbox and descriptive text. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Expanded the clickable area of list rows and improved VoiceOver accessibility.
🎯 Why: Previously, only the tiny circular checkbox icon was clickable. Users had to be very precise with their mouse or trackpad. Wrapping the entire row makes it easier to select/deselect items, improving the overall UX. Additionally, VoiceOver users will now have the entire row read out to them as a single logical unit.
📸 Before/After: Visually identical, but the hit target extends to the bounds of the list row.
♿ Accessibility: Replaced nested buttons with static images, combined children into a single accessibility element to present a cohesive element to screen readers.
PR created automatically by Jules for task 3623575691517973107 started by @acebytes