π‘οΈ Sentinel: [CRITICAL] Fix command injection in toolExists#64
π‘οΈ Sentinel: [CRITICAL] Fix command injection in toolExists#64
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection risk existed in
CacheCategory.swiftwithintoolExistswhereshell("/usr/bin/which \(tool)")directly interpolated the dynamictoolstring into a/bin/bash -cexecuted command string.π― Impact: If the
toolvariable were ever derived dynamically or allowed any user-controlled inputs, it could have resulted in arbitrary command execution on the host machine.π§ Fix: Replaced the
shellwrapper execution with directFoundation.Processinvocation using/usr/bin/envand passing thetoolexclusively throughprocess.arguments = ["which", tool].β Verification: Tested manually that the fix correctly returns whether the tool exists via standard termination status without introducing command injection paths.
PR created automatically by Jules for task 3052558096566051674 started by @acebytes