ci: silence playwright webkit-deps warning + drop orphaned worktree gitlinks#339
Merged
Conversation
… gitlinks Two unrelated CI-log cleanups that frequently confuse PR reviewers. 1. apps/cockpit/playwright.config.ts and apps/website/playwright.config.ts now declare chromium as the only project. Without a projects array, Playwright validates ALL default browsers (chromium + webkit + firefox) on test start and prints a 30-line 'missing system dependencies' warning for the browsers CI doesn't install. Tests run on chromium and pass; the warning is pure noise. 2. Two stray gitlinks under .claude/worktrees/ (website-iteration, zealous-jones) were committed as submodule entries but .gitmodules doesn't exist. Post-job actions/checkout cleanup prints 'fatal: No url found for submodule path' and exits 128 (caught as a warning). .gitignore already excludes .claude/worktrees/ so these don't reappear.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
added a commit
that referenced
this pull request
Jun 9, 2026
… gitlinks (#339) Two unrelated CI-log cleanups that frequently confuse PR reviewers. 1. apps/cockpit/playwright.config.ts and apps/website/playwright.config.ts now declare chromium as the only project. Without a projects array, Playwright validates ALL default browsers (chromium + webkit + firefox) on test start and prints a 30-line 'missing system dependencies' warning for the browsers CI doesn't install. Tests run on chromium and pass; the warning is pure noise. 2. Two stray gitlinks under .claude/worktrees/ (website-iteration, zealous-jones) were committed as submodule entries but .gitmodules doesn't exist. Post-job actions/checkout cleanup prints 'fatal: No url found for submodule path' and exits 128 (caught as a warning). .gitignore already excludes .claude/worktrees/ so these don't reappear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated CI-log cleanups that frequently make PRs look broken when they aren't.
1. Playwright webkit dependencies warning
apps/cockpit/playwright.config.tsandapps/website/playwright.config.tshad noprojectsarray. Without one, Playwright validates ALL default browsers (chromium + webkit + firefox) at test-runner startup and prints a 30-line "missing system dependencies" block listinglibgtk-4.so.1,libwoff2dec.so.1.0.2, etc. — even though tests run on chromium (the only browser the CI step installs) and pass cleanly.Adding
projects: [{ name: 'chromium', use: devices['Desktop Chrome'] }]to both configs scopes the validation to the browser we actually run. No test-logic change.2. Orphaned worktree gitlinks
Two paths under
.claude/worktrees/were committed as submodule entries (160000gitlink mode):.gitmodulesdoesn't exist (nor should it — these are local worktrees that shouldn't ever be tracked). The actions/checkout post-job cleanup tries to deinit them, printsfatal: No url found for submodule path '.claude/worktrees/website-iteration', and exits 128 — caught as a warning..gitignorealready includes.claude/worktrees/, so once these gitlinks are removed, the directories stay ignored.Test plan