docs(scorecard): drop Branch-Protection PAT recommendation#274
Conversation
The spec/plan follow-ups recommended wiring a fine-grained admin:read PAT
(SCORECARD_TOKEN/repo_token) into ossf/scorecard-action to un-exclude the
Branch-Protection check. That's wrong-signed for this repo.
Dawn is a solo-maintainer repo that merges via `gh pr merge --auto --squash`
with intentionally weak protection (strict:false, no required reviews,
enforce_admins:false). An inconclusive (-1) check is excluded from the
Scorecard aggregate mean, so it costs nothing; a *scored* Branch-Protection
check for that posture lands ~4 and would drag the aggregate DOWN. A standing
admin:read PAT is also CI supply-chain surface.
AAF (cacheplane/angular-agent-framework) proved this empirically: wired the
PAT in #689, reverted it in #708 ("let Branch-Protection go inconclusive").
Rewrites the two stale recommendations to the verified stance and corrects
the expected-trajectory table (Branch-Protection no longer contributes).
scorecard.yml stays token-less; no SCORECARD_TOKEN secret.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Claude finished @blove's task in 48s —— View job PR Review: docs(scorecard): drop Branch-Protection PAT recommendation
Verdict: LGTM — documentation-only, logically consistent correction. What changedTwo bullets/sections in the scorecard uplift docs were corrected from "wire a PAT" to "leave inconclusive":
Correctness checkFollow-up #1 rewrite (
Trajectory table (
Current state verification: The PR body confirms no No issues found. The correction is accurate, well-justified, and the trajectory arithmetic is internally consistent. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The Branch-Protection row's Action column still said 'Follow-up (PAT)', contradicting the rewritten follow-up #1. Point it to the no-PAT stance. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Claude finished @blove's task in 1m 17s —— View job PR Review: docs(scorecard): drop Branch-Protection PAT recommendation
SummaryDocumentation-only correction across two files. The reasoning is sound and the technical claims are correct — this PR improves the guidance. What changed:
Correctness of the technical claims:
Consistency between files: Both files now agree — the plan's out-of-scope bullet and the spec's Follow-up #1 carry the same rationale. The trajectory table numbers are consistent with dropping Branch-Protection from the calculation entirely. Minor note (no action needed): The trajectory table shows No bugs, security issues, or type-safety concerns — this is purely documentation. The PR achieves what it says: retracts a wrong-signed recommendation and replaces it with accurate, well-reasoned guidance. Looks good. |
What
Rewrites two stale docs that recommended wiring a fine-grained
Administration: readPAT (SCORECARD_TOKEN/repo_token) intoossf/scorecard-actionto "un-exclude" the OSSF Scorecard Branch-Protection check:docs/superpowers/specs/2026-06-18-ossf-scorecard-uplift-design.md(follow-up feat: inferred tool types via codegen #1 + expected-trajectory table)docs/superpowers/plans/2026-06-18-ossf-scorecard-uplift.md(out-of-scope bullet)Why
The recommendation was wrong-signed for this repo. Dawn is a single-maintainer repo that merges via
gh pr merge --auto --squashwith intentionally weak protection (strict: false,required_pull_request_reviews: null,enforce_admins: false).-1) Branch-Protection check is excluded from the Scorecard aggregate mean — it costs nothing.cacheplane/angular-agent-frameworkproved this empirically: it wired the PAT in #689, then reverted it in #708 ("drop SCORECARD_TOKEN — let Branch-Protection go inconclusive").Verified current state (unchanged by this PR — docs only)
repos/cacheplane/dawnai/branches/main/protection→strict: false,contexts: ["validate"],required_pull_request_reviews: null,required_conversation_resolution: true,enforce_admins: false.gh secret list→ onlyANTHROPIC_API_KEY,NPM_TOKEN(noSCORECARD_TOKEN)..github/workflows/scorecard.yml→publish_results: true, norepo_token. Left as-is.No workflow, secret, or branch-protection changes — documentation only.
🤖 Generated with Claude Code