Conversation
It's been deprecated for almost 30 years, and is causing problems in some cases.
Member
Author
|
Oh, lol, some of our test certs (for tests related to OCSP) only have CN. Will fix... |
Rjevski
reviewed
Mar 5, 2026
| // for convenience, we do want to assemble all the subjects on the certificate | ||
| // into one list (except for CommonName, which has been deprecated for ~30 years, | ||
| // and becomes problematic in several instances, e.g. #356) | ||
| for _, name := range leaf.DNSNames { |
There was a problem hiding this comment.
Are the values in these properties sorted already? If not I'd suggest sorting them, to get a consistent key down the line even if the issuer reshuffles the order of the values.
Member
Author
There was a problem hiding this comment.
They are a slice, so they come in ordered, I assume in the order decoded from the ASN.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been deprecated for almost 30 years, and is causing problems in some cases.