feat: Workflow History V2 - show Remaining Duration for relevant events #1115
+77
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for displaying a Remaining Duration badge in the Duration column of the Workflow History V2 grouped table. The badge shows the remaining time for events that have an expected end time, utilizing the WorkflowHistoryRemainingDurationBadge component introduced in a previous PR.
- Passes
expectedEndTimeInfoprop through the component hierarchy - Renders the Remaining Duration badge alongside the existing duration display when available
- Adds styling for the new flex container to properly layout duration and badge together
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
workflow-history-event-group.tsx |
Passes expectedEndTimeInfo prop to the WorkflowHistoryEventGroupDuration component |
workflow-history-event-group-duration.types.ts |
Adds optional expectedEndTimeInfo property to Props type |
workflow-history-event-group-duration.tsx |
Renders WorkflowHistoryRemainingDurationBadge when expectedEndTimeInfo is provided; wraps content in flex container |
workflow-history-event-group-duration.styles.ts |
Defines new DurationContainer styled component for flex layout |
workflow-history-event-group-duration.test.tsx |
Adds test for rendering the end time badge and includes mock for WorkflowHistoryRemainingDurationBadge |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
macrotim
approved these changes
Dec 12, 2025
...tory-v2/workflow-history-event-group-duration/workflow-history-event-group-duration.types.ts
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display Remaining Duration badge (implemented in #1036) in Duration column in the Grouped History table
Test plan
Updated unit tests + ran locally.
On narrow screens