Minimal changes to allow running on Py3K #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge patch from https://bitbucket.org/dbinit/yolk/ that modifies urllib2.addinfourl to add getheader() method needed to avoid AttributeError in xmlrpclib
Fix cakebread#3 xmlrpc bug in python 2.7.1
Classes should inherit from object
Change all has_key() to "key in container" form Catch exception from gettype() in HTTPMessage and try get_content_type since this object completely changed in Py3K Change print to a function Fix pickle import so it works on Py2 and Py3 Import httplib or http.client for required exception classes Change pickle files to binary Use temp file.TemporaryFile instead of os.tmpfile on Py3K
|
As per the changes listed in the 3.1+ docs under Library Changes[0], I believe the code should be: import picklerather than import cPickle as pickle[0] http://docs.python.org/3.3/whatsnew/3.0.html#library-changes |
Conflicts: tests/test_yolk_cli.py yolk/pypi.py yolk/yolklib.py
Author
|
Updated to support Python 3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all has_key() to "key in container" form
Catch exception from gettype() in HTTPMessage and try get_content_type since this object completely changed in Py3K
Change print to a function
Fix pickle import so it works on Py2 and Py3
Import httplib or http.client for required exception classes
Change pickle files to binary
Use temp file.TemporaryFile instead of os.tmpfile on Py3K