Add docs for Server.terminate event #7790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
reviewed
Jan 2, 2024
| - ``Client`` now emits ``HttpClient.beforeSend`` and ``HttpClient.afterSend`` | ||
| events when requests are sent. You can use these events to perform logging, | ||
| caching or collect telemetry. | ||
| - ``Http\Server::terminate()`` was added. This method triggers the |
Member
There was a problem hiding this comment.
Think we need to mention that this isn't automatically called and point to the other section you added.
othercorey
reviewed
Jan 2, 2024
Comment on lines
+1074
to
+1075
| to run logic **after** the response has been sent to the client. Make sure your | ||
| application's **webroot/index.php** contains the following:: |
Member
There was a problem hiding this comment.
I couldn't write an exact replacement, but think we need to spell out that the changes must be added around the existing emit() call.
New applications created from the app template will include this.
othercorey
reviewed
Jan 2, 2024
|
|
||
| .. warning:: | ||
| In non fastcgi environments the ``Server.terminate`` event is fired before | ||
| the response is sent. |
Member
There was a problem hiding this comment.
Need to add a warning about the scope of the request object used unless we want to make the modification suggested here: cakephp/cakephp#17514 (comment)
Member
There was a problem hiding this comment.
We can just update the example to pull from the container:
cakephp/cakephp#17514 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs cakephp/cakephp#17514