You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allowlist the intentionally bundled pngjs dependency and replace two dynamic provider imports that Rolldown confirmed could not split.
The emitted bundle is 307 bytes smaller overall (114 bytes gzip); the daemon entry is 310 bytes smaller (134 bytes gzip). Build output no longer reports the dependency or ineffective-dynamic-import warnings.
Validation
pnpm check:affected --run passed all runnable checks, including affected coverage, provider-backed integration, Node integration, package verification, and replay-compat provenance.
Reviewed exact head 3d7e9fa76: no code findings. onlyBundle is the intended tsdown whitelist, the static imports preserve wrapper selection/ordering without eager tool/process work, and the exact-head package job proves warning-free build, dependency closure, all public entry imports, and packaged CLI execution.
The sole red check is unrelated: daemon-replace-exit-flush.test.ts expected the deliberately naïve pipe write to truncate, but this runner flushed it. Recent main passed the same test. I requested a failed-job rerun; ready once that clears.
Follow-up: the failed-job rerun (92265262037) reproduced the same failure in test/integration/daemon-replace-exit-flush.test.ts:95: on this runner, the deliberately naïve process.exit() pipe write flushed instead of truncating. This is now an owner-action CI blocker. Please make the shared integration test deterministic, or rebase this PR after that lands on main; no change is requested to #1607’s two-file diff.
Preview removed because the pull request was closed.
2026-08-05 16:24 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allowlist the intentionally bundled
pngjsdependency and replace two dynamic provider imports that Rolldown confirmed could not split.The emitted bundle is 307 bytes smaller overall (114 bytes gzip); the daemon entry is 310 bytes smaller (134 bytes gzip). Build output no longer reports the dependency or ineffective-dynamic-import warnings.
Validation
pnpm check:affected --runpassed all runnable checks, including affected coverage, provider-backed integration, Node integration, package verification, and replay-compat provenance.