Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the S3 object key format from {did}/{hash} to just {hash} to align with Git LFS expectations and enable content-addressed storage using SHA-256 OIDs directly.
Changes:
- Updated S3 object key construction to use only the checksum (hash) instead of the
did/checksumpattern - Modified test scripts and Go code to reflect the new key format
- Updated all test assertions to match the new S3 URL structure
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/scripts/utils/list-s3-by-sha256.sh |
Changed object key construction from ${PREFIX}${did}/${hash} to ${PREFIX}${hash} |
tests/scripts/utils/delete-s3-by-sha256.sh |
Changed object key construction from ${PREFIX}${did}/${hash} to ${PREFIX}${hash} and removed trailing blank lines |
client/indexd/indexd_client.go |
Updated BuildDrsObj to construct S3 URLs using only the checksum instead of did/checksum |
client/indexd/indexd_client_test.go |
Updated test assertions to expect S3 URLs with the new key format (bucket/sha-256 instead of bucket/did-1/sha-256) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matthewpeterkort
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Store objects using checksum-only keys to match Git LFS expectations and enable deterministic, content-addressed storage.
See #171
Description
Use SHA-256 OIDs directly as S3 object keys for DRS access URLs and related S3 utility scripts/tests.