Fix/two tuple errors complete#306
Open
seth-schroeder wants to merge 2 commits intocambiatus:masterfrom
Open
Conversation
Fixes cambiatus/backend/cambiatus#304
+ the custom credo check has false positives when a multi was created in one method, and error handling happens in a different method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note
This is a superset of #305. I wanted to provide two options in case that would be helpful.
What issue does this PR close
Closes #304
Changes Proposed ( a list of new changes introduced by this PR)
Question
contribution_paypal_worker? If I moved the error handling andMulti.newinto the same function, then the linter would correctly see the change. Right now the linter has a false positive in this case (it is on the TODO list)How to test ( a list of instructions on how to test this PR)
Please see #305