Add support for "absolute" root syntax#23
Conversation
|
@m4dz I think I heard you at Snow Camp, nice to comment your PR ;-) So without challenging the value of your proposal, be sure that anyone that uses this trick will deeply understand what risk he takes. |
|
@m4dz thank you for the contribution. Actually I'm considering to forbid to include files with path starting by a However your PR is interesting as it brings the support of relative paths which have not specified About issue #13, I'm not sure this PR will help. From what I understood what it is expected there is to change somehow the img url accordingly to the include path. IMO, it is not something that can be tackled in this plugin. WDYT about modifying your PR to keep only the fix you made on the relative path? |
|
Thanks for your feedback all! I probably misdescribed this feature, so let me bring some light to it 😃 Currently, when you include a file with a path starting with a With this PR, any include path starting with a
(sorry for my misreference to #13, this PR is unrelated) We can see it as a Does it makes more sense? Or did I missed something in your reviews? Thanks! |
|
Hey @camelaissani, any news about this one? Tell me if you need some feedback from me 😃 |
This PR introduces support with the "absolute" path syntax:
./L1/foo.md) or without any leading path (e.g.L1/foo.md), then the inclusion occurs the same way as yet/foo.md), the inclusion path is computed from the root path as declared inoptions.rootIt allows to include files without having to know where the included files is located relatively to the parent file.
It may fix issue #13 by referencing the included file from the root directory by using this "absolute root" syntax.