Skip to content

Update TutorialOverlay.kt#183

Open
candour wants to merge 9 commits into
mainfrom
candour-patch-2
Open

Update TutorialOverlay.kt#183
candour wants to merge 9 commits into
mainfrom
candour-patch-2

Conversation

@candour
Copy link
Copy Markdown
Owner

@candour candour commented Jun 4, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed tutorial overlay visuals: the end-table graphic now renders at a smaller scale and is positioned at the top-left of the tutorial area instead of being centered. This improves alignment and appearance during gameplay tutorials and ensures consistent display across screen sizes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

Warning

Review limit reached

@candour, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e046c94-dbcb-49a2-a4f5-14a630eaf7f0

📥 Commits

Reviewing files that changed from the base of the PR and between 0486f68 and 56f4c3c.

📒 Files selected for processing (1)
  • app/src/main/java/com/messark/hawker/ui/components/TutorialOverlay.kt
📝 Walkthrough

Walkthrough

The GAME_AIM tutorial in TutorialOverlay now computes drawWidth and drawHeight as half the previously scaled values and places the end-table bitmap with its top-left at (0f, 0f) using right = drawWidth and bottom = drawHeight (removing horizontal and vertical centering).

Changes

Tutorial Overlay Sprite Sizing

Layer / File(s) Summary
GAME_AIM end-table sprite size & placement
app/src/main/java/com/messark/hawker/ui/components/TutorialOverlay.kt
drawWidth and drawHeight are set to (srcRect.width * scale)/2 and (srcRect.height * scale)/2; the destination rectangle for the end-table bitmap uses left = 0f, top = 0f, right = drawWidth, bottom = drawHeight instead of centered coordinates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • candour/towerpower#152: Both PRs modify TutorialOverlay.kt’s GAME_AIM end-table sprite rendering—adjusting canvas/draw sizing and related drawWidth/drawHeight and positioning logic.
  • candour/towerpower#175: Both PRs modify the GAME_AIM end-table sprite sizing and placement in the tutorial overlay.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is extremely vague and generic, using only 'Update' without specifying what aspect of TutorialOverlay.kt was changed or why. Provide a more descriptive title that specifies the key changes, such as 'Fix GAME_AIM sprite positioning and scaling in TutorialOverlay' to clarify the actual modifications made.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch candour-patch-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant