Skip to content

John cabaj/add azure fde cmdline#295

Merged
alfonsosanchezbeato merged 1 commit into
canonical:core20from
john-cabaj:john-cabaj/add-azure-fde-cmdline
Apr 24, 2026
Merged

John cabaj/add azure fde cmdline#295
alfonsosanchezbeato merged 1 commit into
canonical:core20from
john-cabaj:john-cabaj/add-azure-fde-cmdline

Conversation

@john-cabaj
Copy link
Copy Markdown

"azure-fde" will become a standalone kernel, thus command line parameters must be passed to this kernel, along with regular "azure" as well to maintain backward compatibility

Backport from canonical/snapd#14864

@alfonsosanchezbeato alfonsosanchezbeato self-requested a review March 22, 2026 16:17
Copy link
Copy Markdown
Contributor

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-cabaj which release do you want to backport this, 20 or 22? There are branches for them in core-initrd. Also, you should backport only the commit from canonical/snapd#14864 , nothing else

@john-cabaj
Copy link
Copy Markdown
Author

@john-cabaj which release do you want to backport this, 20 or 22? There are branches for them in core-initrd. Also, you should backport only the commit from canonical/snapd#14864 , nothing else

Yikes, didn’t mean to have all of that get added. I just wanted to get a draft in place while I tested in a PPA. I’ll fix this up once I’ve fully tested before submitting the PR in full. I only need this in core20.

@john-cabaj john-cabaj changed the base branch from main to core20 March 22, 2026 19:52
@john-cabaj
Copy link
Copy Markdown
Author

Ok, tests made it further than without the changes. Though now I'm getting:

the-tool[246]: 2026/03/23 21:30:44.575018 secboot_tpm.go:202: cannot open TPM connection: no TPM2 device is available

This works for Jammy, so not sure where the disconnect is.

@john-cabaj
Copy link
Copy Markdown
Author

That may have been a red herring. I passed off a virtual TPM to bypass the issue, and still have:

[    2.575410] the-tool[254]: 2026/03/23 21:58:56.343412 cmd_initramfs_mounts.go:90: snap-bootstrap version 2.68.2+ubuntu20.04.3 starting
[  OK  ] Created slice system-systemd\x2dfsck.slice.
[  OK  ] Listening on fsck to fsckd communication Socket.
         Starting File System Check on /dev/sda15...
[  OK  ] Started File System Check Daemon to report status.
[  OK  ] Finished File System Check on /dev/sda15.
         Mounting /run/mnt/ubuntu-seed...
[  OK  ] Mounted /run/mnt/ubuntu-seed.
         Mounting /sysroot...
         Starting File System Check on /dev/sda1...
[  OK  ] Mounted /sysroot.
[  OK  ] Finished File System Check on /dev/sda1.
         Mounting /run/mnt/data...
[    2.821496] EXT4-fs (sda1): mounted filesystem with ordered data mode. Opts: (null). Quota mode: none.

"azure-fde" will become a standalone kernel, thus command line
parameters must be passed to this kernel, along with regular "azure"
as well to maintain backward compatibility

Signed-off-by: John Cabaj <john.cabaj@canonical.com>
@john-cabaj john-cabaj force-pushed the john-cabaj/add-azure-fde-cmdline branch from f476c00 to ea2ee8c Compare April 23, 2026 22:04
@john-cabaj john-cabaj marked this pull request as ready for review April 23, 2026 22:09
Copy link
Copy Markdown
Contributor

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let me know if you are fine with merging it now

@john-cabaj
Copy link
Copy Markdown
Author

Merging ASAP is great.

@alfonsosanchezbeato alfonsosanchezbeato merged commit 6a19b57 into canonical:core20 Apr 24, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants