John cabaj/add azure fde cmdline#295
Conversation
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
@john-cabaj which release do you want to backport this, 20 or 22? There are branches for them in core-initrd. Also, you should backport only the commit from canonical/snapd#14864 , nothing else
Yikes, didn’t mean to have all of that get added. I just wanted to get a draft in place while I tested in a PPA. I’ll fix this up once I’ve fully tested before submitting the PR in full. I only need this in core20. |
|
Ok, tests made it further than without the changes. Though now I'm getting: This works for Jammy, so not sure where the disconnect is. |
|
That may have been a red herring. I passed off a virtual TPM to bypass the issue, and still have: |
"azure-fde" will become a standalone kernel, thus command line parameters must be passed to this kernel, along with regular "azure" as well to maintain backward compatibility Signed-off-by: John Cabaj <john.cabaj@canonical.com>
f476c00 to
ea2ee8c
Compare
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
LGTM - let me know if you are fine with merging it now
|
Merging ASAP is great. |
"azure-fde" will become a standalone kernel, thus command line parameters must be passed to this kernel, along with regular "azure" as well to maintain backward compatibility
Backport from canonical/snapd#14864