Skip to content

[MISC] Fix failures in CI #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragomirp merged 4 commits into from
Jul 21, 2026
Merged

[MISC] Fix failures in CI #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06c260a
Pin ops
dragomirp Jul 20, 2026
1b656cc
SCP as root
dragomirp Jul 20, 2026
4935901
Disable tls
dragomirp Jul 20, 2026
902a431
Get secret client
dragomirp Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements/v1/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ops >= 2.1.1
ops >= 2.1.1,<3.8.0
Comment thread
dragomirp marked this conversation as resolved.
pydantic>=2.11,<3
poetry-core
poetry-core
12 changes: 11 additions & 1 deletion tests/jubilant_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
TLS_ROOT_DIR = "/var/snap/charmed-etcd/current/tls"
CLIENT_PORT = 2379

TLSLIBID = "afd8c2bccf834997afce12c2706d2ede"
CLIENT_TLS_RELATION_NAME = "client-certificates"

logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -73,9 +76,16 @@

tls_path = TLS_ROOT_DIR

for file in ["client.pem", "client.key", "client_ca.pem"]:
for file in ["client.pem", "client_ca.pem"]:
juju.scp(f"{unit}:{tls_path}/{file}", file)

private_key = get_secret_by_label_jubilant(
juju, label=f"{TLSLIBID}-private-key-{unit.split('/')[1]}-{CLIENT_TLS_RELATION_NAME}"
)["private-key"]

with open("client.key", "w") as f:
f.write(private_key)

Check failure

Code scanning / CodeQL

Clear-text storage of sensitive information High test

This expression stores
sensitive data (secret)
Loading
as clear text.
Comment thread
reneradoi marked this conversation as resolved.
Dismissed
Comment thread
dragomirp marked this conversation as resolved.


def get_secret_by_label_jubilant(juju: Juju, label: str) -> Dict[str, str]:
for secret in juju.secrets():
Expand Down