Skip to content

Conversation

@alexdlukens
Copy link

@alexdlukens alexdlukens commented Dec 16, 2025

Fixes #285

Overview

Remove extra slash in _get_backend_proxied_endpoints function in charm.py

@alexdlukens alexdlukens requested a review from a team as a code owner December 16, 2025 22:28
@alexdlukens alexdlukens marked this pull request as draft December 16, 2025 22:33
@Thanhphan1147 Thanhphan1147 added the no-release-note This PR does not require a change artifact label Dec 17, 2025
@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review December 17, 2025 11:14
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Test results for commit 6423805

Test coverage for 6423805

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      0      0      0   100%
----------------------------------------------------------
TOTAL              7      0      0      0   100%

Static code analysis report

Run started:2026-01-05 10:15:47.401317+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 91
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Test results for commit 6423805

Test coverage for 6423805

Name                                         Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------------------
lib/charms/haproxy/v0/haproxy_route_tcp.py     379    169     76      8    51%   197, 200, 248, 257-260, 264-267, 285-288, 303, 309-314, 414, 419, 796-799, 803, 820-841, 859-874, 888-895, 904, 1009-1050, 1054-1060, 1064, 1133-1162, 1233-1272, 1302-1304, 1329-1331, 1353-1357, 1376-1378, 1396-1398, 1405-1411, 1419-1421, 1429-1430, 1441-1448, 1461-1472, 1480-1501, 1514-1515, 1526-1527, 1538-1541, 1552-1553, 1582-1591, 1607-1610, 1626-1637, 1653-1656, 1674-1685, 1696-1697, 1705-1706, 1714-1715, 1726-1729
lib/charms/haproxy/v0/spoe_auth.py             158     55     32      2    59%   203, 304-306, 315, 354-381, 392-402, 441-442, 459-472, 484-501, 522-525, 529-531
lib/charms/haproxy/v1/haproxy_route.py         379     53     96     26    82%   180, 238, 247-250, 275-278, 299-304, 652-653, 839->exit, 846, 872-883, 906-909, 913-915, 934-936, 1108-1114, 1118, 1315->1317, 1319->1321, 1321->1323, 1323->1325, 1325->1327, 1327->1330, 1365, 1373, 1378, 1381, 1406, 1434, 1438, 1442, 1465, 1485, 1494-1495, 1497->exit, 1533-1535, 1555, 1569, 1574-1576
src/charm.py                                   258     71     66      9    67%   96, 217, 225-238, 243, 248, 265, 276, 282-283, 311-331, 384-387, 393->392, 439-447, 475-488, 501-506, 515, 527-541, 546, 556, 562-568, 584
src/haproxy.py                                 104     22      4      1    79%   106-112, 130-145, 247-248, 251, 259-265, 293, 317-319
src/http_interface.py                           73     25      4      0    62%   74, 83, 92, 106-108, 126, 138, 150, 162, 170-175, 187, 194, 202, 217-227
src/state/charm_state.py                        77     15     14      4    79%   93-95, 100-101, 104, 145-150, 159, 208-210, 222-223
src/state/exception.py                           1      0      0      0   100%
src/state/ha.py                                 30      1      2      1    94%   50
src/state/haproxy_route.py                     157      9     48      4    93%   145, 175-180, 247, 290-292, 309
src/state/haproxy_route_tcp.py                  50     18     18      1    51%   74-76, 91->94, 116, 129-142
src/state/ingress.py                            35      0      4      0   100%
src/state/ingress_per_unit.py                   31      0      4      0   100%
src/state/spoe_auth.py                          26      2      2      0    93%   63-64
src/state/tls.py                                40      7     12      4    79%   80, 83-84, 133-140, 146-147
src/state/validation.py                         46     23      8      1    44%   66-67, 71-98
src/tls_relation.py                             56      5     12      4    87%   83-84, 86->85, 113-123, 135->137
----------------------------------------------------------------------------------------
TOTAL                                         1900    475    402     65    71%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Run started:2026-01-05 10:11:50.563908+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 7950
  Total lines skipped (#nosec): 11
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 10

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Test results for commit 6423805

Test coverage for 6423805

Name                               Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------
src/charm.py                          45      9      2      0    77%   65-91, 96-98
src/haproxy_spoe_auth_service.py      44     16      2      0    61%   56-64, 76-82, 93-117
src/state.py                          55     15      6      1    67%   64-66, 79, 125-146
------------------------------------------------------------------------------
TOTAL                                144     40     10      1    68%

Static code analysis report

Run started:2026-01-05 10:10:49.365067

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 409
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147
Copy link
Collaborator

closing as #314 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release-note This PR does not require a change artifact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[haproxy-route] Return apex domain endpoint when no paths defined

5 participants