-
Notifications
You must be signed in to change notification settings - Fork 7
ISD-4727 update haproxy tutorial #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…al/haproxy-operator into ISD-4727_update_haproxy_tutorial
erinecon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for expanding the tutorials for HAProxy! Here's a first round of comments (including one to fix the failing URL check workflow)
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
…al/haproxy-operator into ISD-4727_update_haproxy_tutorial
erinecon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much -- it's really exciting to see advanced tutorials for one of our charms :D I spotted some more nitpicks, with the only major thing being updating the requirements to remove a stray mention of MicroK8s.
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
…al/haproxy-operator into ISD-4727_update_haproxy_tutorial
Test results for commit 9589e03Test coverage for 9589e03 Static code analysis report |
Test results for commit 9589e03Test coverage for 9589e03 Static code analysis report |
Test results for commit 9589e03Test coverage for 9589e03 Static code analysis report |
Moves the haproxy getting started tutorial into the "Tutorial" section, add 2 more tutorials one for TCP and one for gRPC using FTP and flagd respectively
Checklist
docs/release-notes/artifacts. If this PR does not require a change artifact, the PR has been tagged withno-release-note.urgent,trivial,complex)