fix: Remove nginx#19
Open
andylshort wants to merge 1 commit into
Open
Conversation
Brings setup in line with this PR: canonical/maas@ab68c2d Since that PR, when I try to run maas-dev-setup, it would fail in-container when trying to stop the nginx service. This is because `make install-dependencies` wouldn't install it as it was removed from the base package list. This commit fixes this and allows setup to continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings setup script in line with this PR
Since that PR, when I try to run maas-dev-setup, it would fail in-container when trying to stop the nginx service. This is because
make install-dependencieswouldn't install nginx as it was removed from the base package list.This commit fixes this and allows setup to proceed.