Allow multiple setups#23
Conversation
MaikRe
left a comment
There was a problem hiding this comment.
A couple of questions/comments inline
| # you should pick the appropriate ubuntu version. | ||
| # | ||
| # These are currently noble for 3.6+, jammy for 3.4, 3.5 | ||
| UBUNTU_VERSION="noble" |
There was a problem hiding this comment.
You currently do not handle the necessary Ubuntu version differences, i.e. this should include resolute for 3.8 and while resolute is still unreleased this would theoretically also require a specific lxd command to launch the correct version.
There was a problem hiding this comment.
I think I agree... I initially gave up about making an internal mapping because we would have to manually update the code every time for the next 3.X's and 4.X's, and when we don't the user would have to do the manual step in any case, but this is a little hypocrytical since with the current version of the PR we would ideally have to change the default from 3.8 to another one too.
Will make the change.
Still WIP. But some comments:
That being said, it might be worth having a special name (not a number) for "latest". Then we will have to protect an IP range separately from the above (we likely could just reuse the current one for this).