Fixed a minor syntax error I got, plus added a pre check method for doing basic sanity before starting heavy lifting#26
Open
amolvaikar wants to merge 6 commits into
Open
Fixed a minor syntax error I got, plus added a pre check method for doing basic sanity before starting heavy lifting#26amolvaikar wants to merge 6 commits into
amolvaikar wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the MAAS dev environment setup script to fail earlier with clearer messaging and to address a conditional that was causing a syntax error.
Changes:
- Added a
run_pre_checksstep (currently checking for~/.ssh/id_rsa.pub) before running the main setup. - Updated the
MAAS_GITHUB_IDconditional used to add anoriginremote during checkout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
MaikRe
reviewed
Jun 4, 2026
MaikRe
left a comment
MaikRe
left a comment
There was a problem hiding this comment.
Some minor observations regarding comments inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a minor syntax error I got, plus added a pre check method for doing basic sanity before starting heavy lifting