Open
Conversation
Contributor
|
A welcome change :D. I am happy with the overall idea of the PR, will do a thorough review as i do have some nits. Thanks @claudiubelu |
sabaini
requested changes
Aug 29, 2025
Collaborator
sabaini
left a comment
sabaini
left a comment
There was a problem hiding this comment.
Hey @claudiubelu good stuff! One q wrt to cluster_nodes inline
claudiubelu
force-pushed
the
tests-refactor
branch
2 times, most recently
from
2ffa056 to
f228cd8
Compare
There are 2 types of tests being run: single node, and multi node. Adds GitHub actions for these 2 types of scenarios, with the common steps for those scenarios. This should make future tests easier to write and review. Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
claudiubelu
force-pushed
the
tests-refactor
branch
from
f228cd8 to
15ea787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are 2 types of tests being run: single node, and multi node. Adds GitHub actions for these 2 types of scenarios, with the common steps for those scenarios.
This should make future tests easier to write and review.
Type of change
How has this been tested?
Note
All functional changes should accompany corresponding tests (unit tests, functional tests, etc.).
Please describe the addition/modification of tests done to verify this change. Also list any
relevant details for your test configuration.
Contributor checklist
Please check that you have: