internal/rest/resources/control: retry remaining join addresses on client connect err#762
Draft
claudiubelu wants to merge 1 commit into
Draft
internal/rest/resources/control: retry remaining join addresses on client connect err#762claudiubelu wants to merge 1 commit into
claudiubelu wants to merge 1 commit into
Conversation
…ient connect err When joining a cluster, joinWithToken iterates over all addresses in the token to find a reachable cluster member. However, if internalClient.New fails for an address, the function returns immediately instead of trying the next address. This is inconsistent with how other failures in the same loop are handled (GetRemoteCertificate and AddClusterMember both continue to the next address on error). The function now iterates over all the join addresses in this scenario. (cherry picked from commit 39f47c0) Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
claudiubelu
force-pushed
the
v2-join-with-token-err
branch
from
fddf0f3 to
5c777d5
Compare
Contributor
|
Marked as draft until #760 (comment) gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When joining a cluster,
joinWithTokeniterates over all addresses in the token to find a reachable cluster member.However, if
state.Connect().Memberfails for an address, the function returns immediately instead of trying the next address. This is inconsistent with how other failures in the same loop are handled (GetRemoteCertificateandAddClusterMemberboth continue to the next address on error).The function now iterates over all the join addresses in this scenario.
(cherry picked from commit 39f47c0)