Skip to content

Rename "Validator faucet cap" UI label to "Validator liveness reward cap"#5249

Open
samsondav wants to merge 5 commits intocanton-network:mainfrom
Avro-Digital:sam-avro/issue-958-faucet-liveness-ui-labels
Open

Rename "Validator faucet cap" UI label to "Validator liveness reward cap"#5249
samsondav wants to merge 5 commits intocanton-network:mainfrom
Avro-Digital:sam-avro/issue-958-faucet-liveness-ui-labels

Conversation

@samsondav
Copy link
Copy Markdown
Contributor

@samsondav samsondav commented Apr 27, 2026

Summary

Aligns user-facing terminology with the Canton Coin whitepaper, which uses "liveness rewards" rather than "faucet" for the per-round validator rewards. Fixes #958.

  • apps/sv/frontend: relabel the two optValidatorFaucetCap rows in the SV governance minting curve diff view ("Validator faucet cap" -> "Validator liveness reward cap").

Scope

Per the original issue author's guidance ("No changes to Daml code; just UI for now"), this is intentionally minimal:

  • No Daml changes. The final diff leaves splice-amulet untouched to avoid triggering a Daml package/version change.
  • No on-chain ABI changes. The ValidatorLivenessActivityRecord template already exists alongside the deprecated ValidatorFaucetCoupon; the wallet OpenAPI already exposes both endpoint sets. Renaming FaucetState, optValidatorFaucetCap, optIssuancePerValidatorFaucetCoupon, etc. would break on-chain contract compatibility for fields still in active templates and is out of scope.
  • No public API renames. The Scan OpenAPI endpoints (/v0/validators/validator-faucets, /v0/top-validators-by-validator-faucets) are unchanged here. Adding a parallel "liveness" set (mirroring what was done for the wallet API) would be a reasonable follow-up but is a separate concern from a label rename.
  • No internal Scala/test renames. Many internal classes (e.g. ReceiveFaucetCouponTrigger, listValidatorFaucetCouponsOnDomain) still process the deprecated ValidatorFaucetCoupon template -- their names accurately describe what they do. They can be revisited if/when the deprecated template is removed.

Test plan

  • git diff --check
  • npm run format:check --workspace @lfdecentralizedtrust/splice-sv-frontend from apps
  • Reviewed the final PR diff: it is now limited to the two user-facing SV frontend label strings.

…cap"

Aligns user-facing terminology with the Canton Coin whitepaper, which
uses "liveness rewards" rather than "faucet" for these per-round
validator rewards. Per issue canton-network#958, scope is limited to user-visible
text and a stale Daml docstring; the underlying Daml templates and
ABI fields are kept as-is to preserve on-chain compatibility (the
new ValidatorLivenessActivityRecord template already exists alongside
the deprecated ValidatorFaucetCoupon).

- apps/sv/frontend: relabel the optValidatorFaucetCap config rows in
  the SV governance minting curve diff view, and add a unit-test
  assertion pinning the new initial-value and step labels.
- splice-amulet/ValidatorLicense.daml: fix the ValidatorLicense_ReportActive
  docstring to reference the current ValidatorLicense_RecordValidatorLivenessActivity
  choice (instead of the deprecated ReceiveFaucetCoupon) and to contrast
  enabled vs disabled wallets in parallel with the line above.

Fixes canton-network#958

Signed-off-by: Sam Davies <sam@avrofi.com>
@samsondav samsondav force-pushed the sam-avro/issue-958-faucet-liveness-ui-labels branch from e5131ee to 2f42ded Compare April 27, 2026 13:10
@samsondav samsondav force-pushed the sam-avro/issue-958-faucet-liveness-ui-labels branch from 2f42ded to cfd41b3 Compare May 4, 2026 15:16
Comment thread daml/splice-amulet/daml/Splice/ValidatorLicense.daml
@samsondav
Copy link
Copy Markdown
Contributor Author

samsondav commented May 8, 2026

Addressed the review comments: removed the Daml docstring change, removed the added label-only unit test, and updated the PR body/test plan. The final diff is still limited to the two SV frontend label strings.

The first CI run had one wall-clock-time shard fail after its tests passed, during checkErrors log scanning (log/canton_network_test.clog contains problems) with transient TopupMemberTrafficTrigger missing-wallet warnings. I cannot rerun failed jobs directly (Must have admin rights to Repository), so I pushed empty commit de30562c0 to trigger a clean rerun without changing the diff.

@isegall-da the PR is approved, mergeable, and the rerun is blocked only on fork-CI approval:

GitHub reports that my account cannot approve this environment gate, so someone in one of those maintainer/admin teams needs to approve it to let the clean rerun proceed.

Copy link
Copy Markdown
Contributor

@isegall-da isegall-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@isegall-da isegall-da enabled auto-merge (squash) May 8, 2026 14:02
@samsondav samsondav deployed to ci-forks May 8, 2026 14:06 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validator Faucet Rewards -> Validator Liveness Rewards

5 participants