Rename "Validator faucet cap" UI label to "Validator liveness reward cap"#5249
Rename "Validator faucet cap" UI label to "Validator liveness reward cap"#5249samsondav wants to merge 5 commits intocanton-network:mainfrom
Conversation
…cap" Aligns user-facing terminology with the Canton Coin whitepaper, which uses "liveness rewards" rather than "faucet" for these per-round validator rewards. Per issue canton-network#958, scope is limited to user-visible text and a stale Daml docstring; the underlying Daml templates and ABI fields are kept as-is to preserve on-chain compatibility (the new ValidatorLivenessActivityRecord template already exists alongside the deprecated ValidatorFaucetCoupon). - apps/sv/frontend: relabel the optValidatorFaucetCap config rows in the SV governance minting curve diff view, and add a unit-test assertion pinning the new initial-value and step labels. - splice-amulet/ValidatorLicense.daml: fix the ValidatorLicense_ReportActive docstring to reference the current ValidatorLicense_RecordValidatorLivenessActivity choice (instead of the deprecated ReceiveFaucetCoupon) and to contrast enabled vs disabled wallets in parallel with the line above. Fixes canton-network#958 Signed-off-by: Sam Davies <sam@avrofi.com>
e5131ee to
2f42ded
Compare
2f42ded to
cfd41b3
Compare
|
Addressed the review comments: removed the Daml docstring change, removed the added label-only unit test, and updated the PR body/test plan. The final diff is still limited to the two SV frontend label strings. The first CI run had one wall-clock-time shard fail after its tests passed, during @isegall-da the PR is approved, mergeable, and the rerun is blocked only on fork-CI approval:
GitHub reports that my account cannot approve this environment gate, so someone in one of those maintainer/admin teams needs to approve it to let the clean rerun proceed. |
Summary
Aligns user-facing terminology with the Canton Coin whitepaper, which uses "liveness rewards" rather than "faucet" for the per-round validator rewards. Fixes #958.
apps/sv/frontend: relabel the twooptValidatorFaucetCaprows in the SV governance minting curve diff view ("Validator faucet cap" -> "Validator liveness reward cap").Scope
Per the original issue author's guidance ("No changes to Daml code; just UI for now"), this is intentionally minimal:
splice-amuletuntouched to avoid triggering a Daml package/version change.ValidatorLivenessActivityRecordtemplate already exists alongside the deprecatedValidatorFaucetCoupon; the wallet OpenAPI already exposes both endpoint sets. RenamingFaucetState,optValidatorFaucetCap,optIssuancePerValidatorFaucetCoupon, etc. would break on-chain contract compatibility for fields still in active templates and is out of scope./v0/validators/validator-faucets,/v0/top-validators-by-validator-faucets) are unchanged here. Adding a parallel "liveness" set (mirroring what was done for the wallet API) would be a reasonable follow-up but is a separate concern from a label rename.ReceiveFaucetCouponTrigger,listValidatorFaucetCouponsOnDomain) still process the deprecatedValidatorFaucetCoupontemplate -- their names accurately describe what they do. They can be revisited if/when the deprecated template is removed.Test plan
git diff --checknpm run format:check --workspace @lfdecentralizedtrust/splice-sv-frontendfromapps